If you're making consistent profits by buying at $9 and selling at $12, not sure why your broker would want you out of it.
Overall though it's been a relatively poor investment over the past decade. Since its IPO in 1997 the stock has a compound annual growth rate of -5%. That's a sizable annual loss over a 23 year time span. Over the last 10 years, it has a CAGR of -3.7%.
The distribution is nice, but a lot of it is just eaten up by capital losses. There's just better options out there in terms of overall returns.
If we look to the 2 stocks your advisor mentioned, RBC has a CAGR of 8.68% (remember this isn't including dividends) over the 23 year time span and 5.48% over the last decade. Since QSR started trading in 2014, it's CAGR is 10.62%.
Some people get tunnel vision when they see a high distribution like this, but it's important to account for the fact you're still investing initial capital. Which has been shrinking at a pretty decent clip with EIT.
However, with you trading it over the short term like you said, you're making solid gains to go along with a nice distribution. So I can't see why you wouldn't want to continue doing that if you can do it consistently.